Throw an error when changes can't be committed to the databasesqlite-fixes

I was testing and another process had the database open, so it couldn't commit
changes. This wasn't apparent from the UI because it would just silently assume
a commit went fine.

1 files changed, 10 insertions, 1 deletions

diff --git a/src/SemanticScuttle/Service/Bookmark2Tag.php b/src/SemanticScuttle/Service/Bookmark2Tag.php
index 2b95bd8..232fc80 100644
--- a/src/SemanticScuttle/Service/Bookmark2Tag.php
+++ b/src/SemanticScuttle/Service/Bookmark2Tag.php
@@ -208,7 +208,16 @@ class SemanticScuttle_Service_Bookmark2Tag extends SemanticScuttle_DbService
                 return false;
             }
         }
-        $this->db->sql_transaction('commit');
+
+        if ($this->db->sql_transaction('commit')) {
+            $this->db->sql_transaction('rollback');
+            message_die(
+                GENERAL_ERROR, 'Could not commit attaching tags',
+                '', __LINE__, __FILE__, $sql, $this->db
+            );
+            return false;
+        }
+
         return true;
     }