From 85cca718e308779a56dbf302140ce9088fc0727a Mon Sep 17 00:00:00 2001
From: Tom Willemse
Date: Tue, 11 Jun 2024 00:11:58 -0700
Subject: Throw an error when changes can't be committed to the database

I was testing and another process had the database open, so it couldn't commit
changes. This wasn't apparent from the UI because it would just silently assume
a commit went fine.
---
 src/SemanticScuttle/Service/Bookmark2Tag.php | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

(limited to 'src/SemanticScuttle/Service/Bookmark2Tag.php')

diff --git a/src/SemanticScuttle/Service/Bookmark2Tag.php b/src/SemanticScuttle/Service/Bookmark2Tag.php
index 2b95bd8..232fc80 100644
--- a/src/SemanticScuttle/Service/Bookmark2Tag.php
+++ b/src/SemanticScuttle/Service/Bookmark2Tag.php
@@ -208,7 +208,16 @@ class SemanticScuttle_Service_Bookmark2Tag extends SemanticScuttle_DbService
                 return false;
             }
         }
-        $this->db->sql_transaction('commit');
+
+        if ($this->db->sql_transaction('commit')) {
+            $this->db->sql_transaction('rollback');
+            message_die(
+                GENERAL_ERROR, 'Could not commit attaching tags',
+                '', __LINE__, __FILE__, $sql, $this->db
+            );
+            return false;
+        }
+
         return true;
     }
 
-- 
cgit v1.2.3-54-g00ecf