Update/improve docstrings

This commit is contained in:
Tom Willemse 2013-05-04 16:59:26 +02:00
parent 116d7305ee
commit 5b9a60ef74
2 changed files with 53 additions and 22 deletions

2
NEWS
View file

@ -8,6 +8,8 @@
- Simplify ~dispass-add-label~ and ~dispass-remove-label~ by deferring - Simplify ~dispass-add-label~ and ~dispass-remove-label~ by deferring
their functionality to the ~dispass-label~ executable. their functionality to the ~dispass-label~ executable.
- Fix some style warnings for various docstrings.
* Changes in v1.1.1 * Changes in v1.1.1
- Clean up the output from DisPass when prompting, trim whitespace - Clean up the output from DisPass when prompting, trim whitespace

View file

@ -6,7 +6,7 @@
;; Created: Jun 8, 2012 ;; Created: Jun 8, 2012
;; Version: 1.1.1 ;; Version: 1.1.1
;; Keywords: processes ;; Keywords: processes
;; URL: http://ryuslash.org/projects/dispass.el.html ;; URL: http://projects.ryuslash.org/dispass.el/
;; Permission to use, copy, modify, and distribute this software for any ;; Permission to use, copy, modify, and distribute this software for any
;; purpose with or without fee is hereby granted, provided that the ;; purpose with or without fee is hereby granted, provided that the
@ -24,11 +24,14 @@
;;; Commentary: ;;; Commentary:
;; dispass.el is an emacs wrapper around DisPass ;; dispass.el is an Emacs wrapper around DisPass
;; (http://dispass.babab.nl). For more information see the README.org ;; (http://dispass.babab.nl). For more information see the README.org
;; and NEWS files. ;; and NEWS files.
;; This version is written for use with DisPass v0.2.0.
;;; Code: ;;; Code:
(defgroup dispass nil (defgroup dispass nil
"Customization options for the DisPass wrapper." "Customization options for the DisPass wrapper."
:group 'external) :group 'external)
@ -54,8 +57,9 @@
:risky t) :risky t)
(defcustom dispass-labelfile nil (defcustom dispass-labelfile nil
"The location of your preferred labelfile, a value of `nil' "The location of your preferred labelfile.
means to just let DisPass figure it out."
A value of nil means to just let DisPass figure it out."
:package-version '(dispass . "1.1.1") :package-version '(dispass . "1.1.1")
:group 'dispass :group 'dispass
:type 'file :type 'file
@ -68,13 +72,14 @@
(define-key map "a" 'dispass-add-label) (define-key map "a" 'dispass-add-label)
(define-key map "d" 'dispass-remove-label) (define-key map "d" 'dispass-remove-label)
map) map)
"Keymap for `dispass-labels-mode', uses "Keymap for `dispass-labels-mode'.
`tabulated-list-mode-map' as its parent.")
Uses `tabulated-list-mode-map' as its parent.")
;; This should be extracted from DisPass at some point.
(defconst dispass-algorithms (defconst dispass-algorithms
'("dispass1" "dispass2") '("dispass1" "dispass2")
"The list of algorithms supported by DisPass, this should be "The list of algorithms supported by DisPass.")
extracted from DisPass at some point.")
(defun dispass-process-sentinel (proc status) (defun dispass-process-sentinel (proc status)
"Report PROC's status change to STATUS." "Report PROC's status change to STATUS."
@ -87,7 +92,7 @@
(kill-buffer buffer)))) (kill-buffer buffer))))
(defun dispass-erase-buffer (buffer) (defun dispass-erase-buffer (buffer)
"Completely erase the contents of BUFFER" "Completely erase the contents of BUFFER."
(save-current-buffer (save-current-buffer
(set-buffer buffer) (set-buffer buffer)
(buffer-disable-undo buffer) (buffer-disable-undo buffer)
@ -99,8 +104,11 @@
(tabulated-list-get-id))) (tabulated-list-get-id)))
(defun dispass-process-filter-for (label) (defun dispass-process-filter-for (label)
"Create a function that will process any lines whilst keeping "Create a specialized filter for LABEL.
an eye out for LABEL."
This filter checks if a password has been asked for or if the
label shows up in a line, which will be the line with the
passphrase that has been generated."
`(lambda (proc string) `(lambda (proc string)
"Process STRING coming from PROC." "Process STRING coming from PROC."
(cond ((string-match "^\\(Password[^:]*\\|Again\\): ?$" string) (cond ((string-match "^\\(Password[^:]*\\|Again\\): ?$" string)
@ -121,10 +129,16 @@ an eye out for LABEL."
(defun dispass-start-process (label create length (defun dispass-start-process (label create length
&optional algo seqno args) &optional algo seqno args)
"Start dispass process. When CREATE is non-nil send along the "Ask DisPass to generate a passphrase for LABEL.
-c switch to make it ask for a password twice. When LENGTH is
an integer and greater than 0, send along the -l switch with When CREATE is non-nil send along the -c switch to make it ask
LENGTH." for a password twice. When LENGTH is an integer and greater than
0, we request that DisPass make the passphrase LENGTH long. ALGO
should be one of `dispass-algorithms' and requests a certain
algorithm be used by DisPass to generate the passphrase. SEQNO
asks DisPass to use SEQNO as a sequence number.
If specified add ARGS to the command."
(let ((args `("-o" ,@args ,label)) (let ((args `("-o" ,@args ,label))
proc) proc)
(when create (when create
@ -194,7 +208,10 @@ an eye out for LABEL."
;;;###autoload ;;;###autoload
(defun dispass-create (label &optional length algo seqno) (defun dispass-create (label &optional length algo seqno)
"Create a new password for LABEL." "Create a new password for LABEL.
Optionally also specify to make the passphrase LENGTH long, use
the ALGO algorithm with sequence number SEQNO."
(interactive (list (interactive (list
(read-from-minibuffer "Label: ") (read-from-minibuffer "Label: ")
current-prefix-arg current-prefix-arg
@ -206,7 +223,12 @@ an eye out for LABEL."
;;;###autoload ;;;###autoload
(defun dispass (label &optional length algo seqno) (defun dispass (label &optional length algo seqno)
"Recreate a password previously used." "Recreate a passphrase for LABEL.
Optionally also specify to make the passphrase LENGTH long, use
the ALGO algorithm with sequence number SEQNO. This is useful
when you would like to generate a one-shot passphrase, or prefer
not to have LABEL added to your labelfile for some other reason."
(interactive (list (interactive (list
(completing-read (completing-read
"Label: " (dispass-get-labels)) "Label: " (dispass-get-labels))
@ -224,7 +246,9 @@ an eye out for LABEL."
;; Labels management ;; Labels management
;;;###autoload ;;;###autoload
(defun dispass-add-label (label length algo &optional seqno) (defun dispass-add-label (label length algo &optional seqno)
"Add LABEL with length LENGTH and algorithm ALGO to DisPass." "Add LABEL with length LENGTH and algorithm ALGO to DisPass.
Optionally also specify sequence number SEQNO."
(interactive (interactive
(list (read-from-minibuffer "Label: ") (list (read-from-minibuffer "Label: ")
(read-from-minibuffer (read-from-minibuffer
@ -244,10 +268,11 @@ an eye out for LABEL."
;;;###autoload ;;;###autoload
(defun dispass-remove-label (label) (defun dispass-remove-label (label)
"Remove LABEL from DisPass, if LABEL is not given "Remove LABEL from DisPass.
`tabulated-list-get-id' will be used to get the currently
pointed-at label. If neither LABEL is not found an error is If LABEL is not given `tabulated-list-get-id' will be used to get
thrown." the currently pointed-at label. If neither LABEL is not found an
error is thrown."
(interactive (interactive
(list (or (dispass-label-at-point) (list (or (dispass-label-at-point)
(completing-read (completing-read
@ -298,3 +323,7 @@ thrown."
(provide 'dispass) (provide 'dispass)
;;; dispass.el ends here ;;; dispass.el ends here
;; Local Variables:
;; sentence-end-double-space: t
;; End: