diff options
| author |  Tom Willemsen | 2012-06-23 11:41:27 +0200 |
|---|---|---|
| committer | Tom Willemsen | 2012-06-23 11:41:27 +0200 |
| commit | 440a19d806d64398f644aaf0fb483010f6cadaf3 (patch) | |
| tree | 9b094829df5e100a4698511f2f3602520de2847a | |
| parent | 360d129a0c1ac0f190f41537db7a6d3d5f510954 (diff) | |
| download | git-auto-commit-mode-440a19d806d64398f644aaf0fb483010f6cadaf3.tar.gz git-auto-commit-mode-440a19d806d64398f644aaf0fb483010f6cadaf3.zip | |
Rename gac-automatically-push
It is normal for boolean values, or predicates, to end with `-p' in
emacs-lisp, so `gac-automatically-push' should really be named
`gac-automatically-push-p'.
| -rw-r--r-- | git-auto-commit-mode.el | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/git-auto-commit-mode.el b/git-auto-commit-mode.el index 70ee0ca..388a03d 100644 --- a/git-auto-commit-mode.el +++ b/git-auto-commit-mode.el @@ -39,12 +39,15 @@ ;; 4 - Make `gac-automatically-push' buffer local, always. +;; - Rename `gac-automatically-push' to `gac-automatically-push-p' +;; to follow standard emacs-lisp conventions. + ;;; Code: -(defvar gac-automatically-push nil +(defvar gac-automatically-push-p nil "Control whether or not `git-auto-commit-mode' should also automatically push the changes.") -(make-variable-buffer-local 'gac-automatically-push) +(make-variable-buffer-local 'gac-automatically-push-p) (defun gac-relative-file-name (filename) "Find the path to the filename relative to the git directory" @@ -103,9 +106,9 @@ already have been set up." (defun gac-after-save-func () "Commit the changes to the current file, and when -`gac-automatically-push' is not `nil', push." +`gac-automatically-push-p' is not `nil', push." (gac-commit) - (when gac-automatically-push + (when gac-automatically-push-p (gac-push))) ;;;###autoload |