diff options
| author |  Matus Goljer | 2017-05-24 11:15:59 +0200 |
|---|---|---|
| committer |  GitHub | 2017-05-24 11:15:59 +0200 |
| commit | 47aaf2c9a0beb0a530430b9c12ec148af6a2bd88 (patch) | |
| tree | 49eac4c567f1a9ac365c94048cc212c1f29947b0 | |
| parent | b58708d15a6659577945c0aa3a63983eebff2e67 (diff) | |
| download | nginx-mode-47aaf2c9a0beb0a530430b9c12ec148af6a2bd88.tar.gz nginx-mode-47aaf2c9a0beb0a530430b9c12ec148af6a2bd88.zip | |
Remove `run-hook`, it is run automatically.
Hi.
When using `define-derived-mode` one doesn't need (and shouldn't) use `run-hook` because the macro adds the form `run-mode-hook` itself when expanded (use macroexpand to check!).
This results in the hook being called twice, see
```elisp
(defun my-nginx-mode-init ()
(message "Hello"))
(add-hook 'nginx-mode-hook 'my-nginx-mode-init)
```
In messages I have
Hello [2 times]
Simply removing the form and using the one provided by the macro is enough to fix this.
| -rw-r--r-- | nginx-mode.el | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/nginx-mode.el b/nginx-mode.el index 9cf79e2..b038532 100644 --- a/nginx-mode.el +++ b/nginx-mode.el @@ -184,8 +184,7 @@ The variable nginx-indent-level controls the amount of indentation. (set (make-local-variable 'paragraph-separate) "\\([ \f]*\\|#\\)$") (set (make-local-variable 'font-lock-defaults) - '(nginx-font-lock-keywords nil)) - (run-hooks 'nginx-mode-hook)) + '(nginx-font-lock-keywords nil))) ;;;###autoload (add-to-list 'auto-mode-alist '("nginx\\.conf\\'" . nginx-mode)) |