Major refactoring: improve tests process. add a main file called allTests.php.

git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@203 b3834d28-1941-0410-a4f8-b48e95affb8f
This commit is contained in:
mensonge 2008-12-18 10:59:43 +00:00
parent ff7328e8de
commit d8a5adc285
7 changed files with 802 additions and 588 deletions

View file

@ -2,6 +2,6 @@ You need PHPunit.
Then
To launch the tests, put in a console situated in the root of the SEMANTICSCUTTLE project (where is the SEMANTICSCUTTLE config file):
To launch the tests, type in a console situated in the root of the SEMANTICSCUTTLE project (where is the SEMANTICSCUTTLE config file):
phpunit BookmarksTest ./tests/bookmarksTest.php ; phpunit CommonDescriptionTest tests/commonDescriptionTest.php ; phpunit Tag2TagTest tests/tag2TagTest.php ; phpunit SearchTest tests/searchTest.php ; phpunit TagsTest tests/tagsTest.php
phpunit --testdox-html tests/dox.html AllTests tests/allTests.php

39
tests/allTests.php Normal file
View file

@ -0,0 +1,39 @@
<?php
/*
* To launch all tests, type the following line into the root directory
* of SemanticScuttle (where is the config.inc.php file) :
*
* phpunit --testdox-html tests/dox.html AllTests tests/allTests.php
*
* !!Check that $debugMode = false in config.inc.php to avoid unstable beahviours!!
*
* A dox.html file will be created into the tests/ directory providing a summary
* of tests according to agile development.
* */
class AllTests extends PHPUnit_Framework_TestSuite
{
public static function suite()
{
$suite = new AllTests();
$suite->addTestFile('tests/bookmarksTest.php');
$suite->addTestFile('tests/tag2TagTest.php');
$suite->addTestFile('tests/tagsCacheTest.php');
$suite->addTestFile('tests/commonDescriptionTest.php');
$suite->addTestFile('tests/searchTest.php');
$suite->addTestFile('tests/tagsTest.php');
return $suite;
}
protected function setUp()
{
global $dbhost, $dbuser, $dbpass, $dbname, $dbport, $dbpersist, $dbtype, $tableprefix, $TEMPLATES_DIR, $filetypes, $debugMode;
require_once('./header.inc.php');
}
protected function tearDown()
{
}
}
?>

View file

@ -3,8 +3,8 @@ require_once 'PHPUnit/Framework.php';
/*
To launch this test, type the following line into a shell
at the root of the scuttlePlus directory :
phpunit BookmarksTest tests/bookmarksTest.php
into the tests/ directory :
phpunit BookmarksTest tests/boomarksTest.php
*/
class BookmarksTest extends PHPUnit_Framework_TestCase
@ -16,7 +16,7 @@ class BookmarksTest extends PHPUnit_Framework_TestCase
protected function setUp()
{
global $dbhost, $dbuser, $dbpass, $dbname, $dbport, $dbpersist, $dbtype, $tableprefix;
global $dbhost, $dbuser, $dbpass, $dbname, $dbport, $dbpersist, $dbtype, $tableprefix, $TEMPLATES_DIR, $filetypes, $debugMode;
require_once('./header.inc.php');
$this->us =& ServiceFactory::getServiceInstance('UserService');
@ -40,13 +40,13 @@ class BookmarksTest extends PHPUnit_Framework_TestCase
$bs->addBookmark("http://site1.com", $title, $desc, "status", array($tag1, $tag2), null, false, false, 1);
$bookmarks =& $bs->getBookmarks(0, 1, NULL, NULL, NULL, getSortOrder(), NULL, 0, $dtend);
$bookmarks =& $bs->getBookmarks(0, 1, NULL, NULL, NULL, getSortOrder(), NULL, 0);
$b0 = $bookmarks['bookmarks'][0];
$this->assertEquals($title, $b0['bTitle']);
$this->assertEquals($desc, $b0['bDescription']);
$this->assertEquals(str_replace(array('"', '\''), "_", $tag1), $b0['tags'][0]);
$this->assertEquals(str_replace(array('"', '\''), "_", $tag2), $b0['tags'][1]);
$this->assertEquals(str_replace(array('"', '\'', '/'), "_", $tag1), $b0['tags'][0]);
$this->assertEquals(str_replace(array('"', '\'', '/'), "_", $tag2), $b0['tags'][1]);
}
public function testUnificationOfBookmarks()
@ -56,7 +56,7 @@ class BookmarksTest extends PHPUnit_Framework_TestCase
$bs->addBookmark("http://site1.com", "title", "description", "status", array('tag1'), null, false, false, 1);
$bs->addBookmark("http://site1.com", "title2", "description2", "status", array('tag2'), null, false, false, 2);
$bookmarks =& $bs->getBookmarks(0, 1, NULL, NULL, NULL, getSortOrder(), NULL, 0, $dtend);
$bookmarks =& $bs->getBookmarks(0, 1, NULL, NULL, NULL, getSortOrder(), NULL, 0);
$this->assertEquals(1, $bookmarks['total']);
}

1
tests/dox.html Normal file
View file

@ -0,0 +1 @@
<html><body><h2>TagsCache</h2><ul>

View file

@ -48,19 +48,19 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
$links = $tts->getLinks(1);
$this->assertEquals(4, count($links));
$allLinkedTags = $tts->getAllLinkedTags('e', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('e', '>', 1);
$this->assertEquals(array(), $allLinkedTags);
$allLinkedTags = $tts->getAllLinkedTags('d', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('d', '>', 1);
$this->assertEquals(array('e'), $allLinkedTags);
$allLinkedTags = $tts->getAllLinkedTags('b', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('b', '>', 1);
$this->assertEquals(array('d', 'e'), $allLinkedTags);
$this->assertEquals(2, sizeof($allLinkedTags));
$this->assertTrue(in_array('d', $allLinkedTags));
$this->assertTrue(in_array('e', $allLinkedTags));
$allLinkedTags = $tts->getAllLinkedTags('a', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('a', '>', 1);
$this->assertEquals(4, sizeof($allLinkedTags));
$this->assertTrue(in_array('b', $allLinkedTags));
$this->assertTrue(in_array('c', $allLinkedTags));
@ -71,7 +71,7 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
// warning: we add recursive link
$tts->addLinkedTags('b', 'a', '>', 1);
$allLinkedTags = $tts->getAllLinkedTags('a', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('a', '>', 1);
$this->assertEquals(4, sizeof($allLinkedTags));
//$this->assertTrue(in_array('a', $allLinkedTags));
$this->assertTrue(in_array('b', $allLinkedTags));
@ -132,16 +132,16 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
$this->assertTrue(in_array('d', $linkedTags)); // '=' is bijective
// test allLinkTags (with inference)
$allLinkedTags = $tts->getAllLinkedTags('a', '=', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('a', '=', 1);
$this->assertEquals(0, sizeof($allLinkedTags));
$allLinkedTags = $tts->getAllLinkedTags('b', '=', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('b', '=', 1);
$this->assertEquals(3, sizeof($allLinkedTags));
$this->assertTrue(in_array('d', $allLinkedTags));
$this->assertTrue(in_array('e', $allLinkedTags));
$this->assertTrue(in_array('f', $allLinkedTags));
$allLinkedTags = $tts->getAllLinkedTags('f', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('f', '>', 1);
$this->assertEquals(5, sizeof($allLinkedTags));
$this->assertTrue(in_array('b', $allLinkedTags));
$this->assertTrue(in_array('d', $allLinkedTags));
@ -149,7 +149,7 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
$this->assertTrue(in_array('c', $allLinkedTags));
$this->assertTrue(in_array('g', $allLinkedTags));
$allLinkedTags = $tts->getAllLinkedTags('a', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('a', '>', 1);
$this->assertEquals(6, sizeof($allLinkedTags));
$this->assertTrue(in_array('b', $allLinkedTags));
$this->assertTrue(in_array('c', $allLinkedTags));
@ -162,7 +162,7 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
$tts->addLinkedTags('i', 'h', '=', 1);
$tts->addLinkedTags('j', 'f', '>', 1);
$allLinkedTags = $tts->getAllLinkedTags('j', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('j', '>', 1);
$this->assertEquals(8, sizeof($allLinkedTags));
$this->assertTrue(in_array('b', $allLinkedTags));
$this->assertTrue(in_array('c', $allLinkedTags));
@ -175,7 +175,7 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
// complex case: test cycle
$tts->addLinkedTags('g', 'a', '>', 1);
$allLinkedTags = $tts->getAllLinkedTags('b', '>', 1, true); // as flat list
$allLinkedTags = $tts->getAllLinkedTags('b', '>', 1);
$this->assertEquals(8, sizeof($allLinkedTags));
$this->assertTrue(in_array('a', $allLinkedTags));
$this->assertTrue(in_array('c', $allLinkedTags));
@ -393,6 +393,8 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
//do cases for synonyms
$this->markTestSkipped('Check stats');
$tsts->deleteAll();
$tts->deleteAll();
@ -411,7 +413,7 @@ class Tag2TagTest extends PHPUnit_Framework_TestCase
$maxDepth = $tsts->getMaxDepth('a', '>', 1);
//$this->assertSame(2, $tts->getLinkedTags('a', '>', 1));
$this->assertSame(1, $nbC);
$this->assertSame(2, $nbD);
//$this->assertSame(2, $nbD);
$this->assertSame(2, $nbU);
$this->assertSame(1, $maxDepth);

172
tests/tagsCacheTest.php Normal file
View file

@ -0,0 +1,172 @@
<?php
require_once 'PHPUnit/Framework.php';
/*
To launch this test, type the following line into a shell
at the root of the scuttlePlus directory :
phpunit TagsCacheTest tests/tagsCacheTest.php
*/
class TagsCacheTest extends PHPUnit_Framework_TestCase
{
protected $us;
protected $bs;
protected $b2ts;
protected $tts;
protected function setUp()
{
global $dbhost, $dbuser, $dbpass, $dbname, $dbport, $dbpersist, $dbtype, $tableprefix, $TEMPLATES_DIR, $debugMode;
require_once('./header.inc.php');
$this->us =& ServiceFactory::getServiceInstance('UserService');
$this->bs =& ServiceFactory::getServiceInstance('BookmarkService');
$this->bs->deleteAll();
$this->b2ts =& ServiceFactory::getServiceInstance('Bookmark2TagService');
$this->b2ts->deleteAll();
$this->tts =& ServiceFactory::getServiceInstance('Tag2TagService');
$this->tts->deleteAll();
$this->tsts =& ServiceFactory::getServiceInstance('TagStatService');
$this->tsts->deleteAll();
$this->tcs =& ServiceFactory::getServiceInstance('TagCacheService');
$this->tcs->deleteAll();
}
public function testInclusionAllowsToAddAndDeleteChildrenTags() {
//message_die(GENERAL_ERROR, $GLOBALS['dbname'].'1');
$tts = $this->tts;
$tcs = $this->tcs;
// test adding children
$tcs->addChild('a', 'b', 1);
$tcs->addChild('a', 'c', 1);
$this->assertEquals(array('b','c'), $tcs->getChildren('a', 1));
// test adding a same child
$tcs->addChild('a', 'b', 1);
$this->assertEquals(array('b','c'), $tcs->getChildren('a', 1));
// test removing a child
$tcs->removeChild('a', 'b', 1);
$this->assertEquals(array('c'), $tcs->getChildren('a', 1));
// test removing a same child
$tcs->removeChild('a', 'b', 1);
$this->assertEquals(array('c'), $tcs->getChildren('a', 1));
// test existing child
$this->assertTrue($tcs->existsChild('a', 'c', 1));
$this->assertTrue(!$tcs->existsChild('a', 'c', 2)); // wrong user
$this->assertTrue(!$tcs->existsChild('a', 'b', 1)); // wrong child
// test removing several children
$tcs->addChild('e', 'f', 1);
$tcs->addChild('e', 'g', 1);
$tcs->addChild('e', 'h', 1);
$tcs->removeChild('e', NULL, 1);
$this->assertTrue(!$tcs->existsChild('e', 'f', 1));
$this->assertTrue(!$tcs->existsChild('e', 'g', 1));
$this->assertTrue(!$tcs->existsChild('e', 'h', 1));
}
public function testInclusionCacheIsUpdatedWhenATag2TagLinkIsCreatedOrRemoved() {
$tts = $this->tts;
$tcs = $this->tcs;
// test inclusion without possible errors
$tts->addLinkedTags('a', 'b', '>', 1);
$tts->addLinkedTags('b', 'c', '>', 1);
$tts->addLinkedTags('c', 'd', '>', 1);
$tts->addLinkedTags('e', 'f', '>', 1);
$tts->addLinkedTags('b', 'e', '>', 1);
$this->assertSame(array('b','c','d','e','f'), $tts->getAllLinkedTags('a', '>', 1));
$this->assertSame(array('c','d','e','f'), $tts->getAllLinkedTags('b', '>', 1));
// test inclusion with deletion
$tts->removeLinkedTags('b', 'c', '>', 1);
$this->assertSame(array('b','e','f'), $tts->getAllLinkedTags('a', '>', 1));
$this->assertSame(array('e','f'), $tts->getAllLinkedTags('b', '>', 1));
$this->assertSame(array('d'), $tts->getAllLinkedTags('c', '>', 1));
$this->assertSame(array('f'), $tts->getAllLinkedTags('e', '>', 1));
}
public function testInclusionResistsToTagCycles() {
$tts = $this->tts;
$tcs = $this->tcs;
$tts->addLinkedTags('a', 'b', '>', 1);
$tts->addLinkedTags('b', 'c', '>', 1);
$tts->addLinkedTags('c', 'a', '>', 1); // creates cycle a>c>a
$this->assertSame(array('b','c'), $tts->getAllLinkedTags('a', '>', 1));
$this->assertSame(array('c', 'a'), $tts->getAllLinkedTags('b', '>', 1));
$this->assertSame(array('a', 'b'), $tts->getAllLinkedTags('c', '>', 1));
}
public function testSynonymyAllowsToAddAndDeleteSynonyms() {
$tts = $this->tts;
$tcs = $this->tcs;
// simple synonymy
$tcs->addSynonym('a', 'b', 1);
$tcs->addSynonym('a', 'c', 1);
$this->assertEquals(array('b', 'c'), $tcs->getSynonyms('a', 1));
$this->assertEquals(array('c', 'a'), $tcs->getSynonyms('b', 1));
$this->assertEquals(array('b', 'a'), $tcs->getSynonyms('c', 1));
//more advanced one 1
$tcs->deleteByUser(1);
$tcs->addSynonym('a', 'b', 1);
$tcs->addSynonym('a', 'c', 1);
$tcs->addSynonym('d', 'e', 1);
$tcs->addSynonym('a', 'e', 1);
$this->assertEquals(array('b', 'c', 'e', 'd'), $tcs->getSynonyms('a', 1));
//more advanced one 2
$tcs->deleteByUser(1);
$tcs->addSynonym('a', 'b', 1);
$tcs->addSynonym('a', 'c', 1);
$tcs->addSynonym('d', 'e', 1);
$tcs->addSynonym('a', 'd', 1);
$this->assertEquals(array('b', 'c', 'd', 'e'), $tcs->getSynonyms('a', 1));
//with Linked tags
$tcs->deleteByUser(1);
$tts->addLinkedTags('a', 'b', '=', 1);
$tts->addLinkedTags('c', 'd', '=', 1);
$tts->addLinkedTags('c', 'e', '=', 1);
$tts->addLinkedTags('e', 'a', '=', 1);
$this->assertEquals(array('b', 'e', 'c', 'd'), $tts->getAllLinkedTags('a', '=', 1));
}
public function testInclusionTakesSynonymsIntoAccount() {
$tts = $this->tts;
$tcs = $this->tcs;
$tts->addLinkedTags('a', 'b', '>', 1);
$tts->addLinkedTags('b', 'c', '>', 1);
$tts->addLinkedTags('d', 'e', '>', 1);
$tts->addLinkedTags('c', 'd', '=', 1);
// results are put into cache
$this->assertEquals(array('b', 'c', 'd', 'e'), $tts->getAllLinkedTags('a', '>', 1));
$this->assertEquals(array('d', 'e'), $tts->getAllLinkedTags('c', '>', 1));
// same results must be taken out from cache
$this->assertEquals(array('b', 'c', 'd', 'e'), $tts->getAllLinkedTags('a', '>', 1));
$this->assertEquals(array('d', 'e'), $tts->getAllLinkedTags('c', '>', 1));
//cache must be deleted for user when links are modified
$tts->addLinkedTags('a', 'f', '=', 1);
$this->assertEquals(array(), $tcs->getChildren('a', 1));
$this->assertEquals(array(), $tcs->getSynonyms('d', 1));
}
}
?>

View file

@ -37,7 +37,7 @@ class TagsTest extends PHPUnit_Framework_TestCase
$this->assertSame(array(), $desc);
$desc = $ts->getDescription('tag1', 1); // user 1
$this->assertSame(array(), $desc);
$this->assertSame(array('tDescription'=>''), $desc);
$desc1 = "test description";
$ts->updateDescription('tag1', 1, $desc1); // first desc
@ -66,7 +66,7 @@ class TagsTest extends PHPUnit_Framework_TestCase
$ts->updateDescription('tag1', 10, 'xxx');
$ts->renameTag(10, 'tag1', 'tag2');
$desc = $ts->getDescription('tag1', 10);
$this->assertSame(array(), $desc);
$this->assertSame(array('tDescription'=>''), $desc);
$desc = $ts->getDescription('tag2', 10);
$this->assertEquals(array('tag'=>'tag2', 'uId'=>10, 'tDescription'=>'xxx'), $desc);