aliens/SemanticScuttle
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

replace regex email validation with PHP filter function and remove DNS checking functions that were not used anymore and do even had a security issue since they did not escape shell parameters

Browse source 
git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@568 b3834d28-1941-0410-a4f8-b48e95affb8f
This commit is contained in:
cweiske 2009-11-20 17:41:31 +00:00
parent fdaee8f05d
commit cc5b3d0b5e
1 changed files with 10 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
src/SemanticScuttle/Service/User.php
View file

@ -76,26 +76,6 @@ class SemanticScuttle_Service_User extends SemanticScuttle_DbService
$this->updateSessionStability(); $this->updateSessionStability();
} }
function _checkdns($host) {
if (function_exists('checkdnsrr')) {
return checkdnsrr($host);
} else {
return $this->_checkdnsrr($host);
}
}
function _checkdnsrr($host, $type = "MX") {
if(!empty($host)) {
@exec("nslookup -type=$type $host", $output);
while(list($k, $line) = each($output)) {
if(eregi("^$host", $line)) {
return true;
}
}
return false;
}
}
function _getuser($fieldname, $value) { function _getuser($fieldname, $value) {
$query = 'SELECT * FROM '. $this->getTableName() .' WHERE '. $fieldname .' = "'. $this->db->sql_escape($value) .'"'; $query = 'SELECT * FROM '. $this->getTableName() .' WHERE '. $fieldname .' = "'. $this->db->sql_escape($value) .'"';
@ -700,16 +680,16 @@ class SemanticScuttle_Service_User extends SemanticScuttle_DbService
function isValidEmail($email) { /**
if (eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,6})$", $email)) { * Checks if the given email address is valid
list($emailUser, $emailDomain) = split("@", $email); *
* @param string $email Email address
// Check if the email domain has a DNS record *
//if ($this->_checkdns($emailDomain)) { * @return boolean True if it is valid, false if not
return true; */
//} public function isValidEmail($email)
} {
return false; return filter_var($email, FILTER_VALIDATE_EMAIL) !== false;
} }
/** /**