aliens/SemanticScuttle
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix notice when passing an invalid array to editAllowed()

Browse source 
git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@558 b3834d28-1941-0410-a4f8-b48e95affb8f
This commit is contained in:
cweiske 2009-11-19 19:22:21 +00:00
parent c93455201a
commit 563df90c75
2 changed files with 59 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/SemanticScuttle/Service/Bookmark.php
View file

@ -206,8 +206,11 @@ class SemanticScuttle_Service_Bookmark extends SemanticScuttle_DbService
*/
function editAllowed($bookmark)
{
if (!is_numeric($bookmark) && (!is_array($bookmark)
|| !is_numeric($bookmark['bId']))
if (!is_numeric($bookmark)
&& (!is_array($bookmark)
|| !isset($bookmark['bId'])
|| !is_numeric($bookmark['bId'])
)
) {
return false;
}

54
tests/BookmarkTest.php
View file

@ -269,6 +269,60 @@ class BookmarkTest extends TestBase
/**
* Test if editAllowed() returns false when the bookmark
* id is invalid.
*
* @return void
*/
public function testEditAllowedInvalidBookmarkId()
{
$this->assertFalse($this->bs->editAllowed('invalid'));
$this->assertFalse($this->bs->editAllowed(array()));
$this->assertFalse($this->bs->editAllowed(array('some', 'where')));
$this->assertFalse($this->bs->editAllowed(array('bId' => false)));
$this->assertFalse($this->bs->editAllowed(array('bId' => 'foo')));
}
/**
* Test if editAllowed() works when passing the ID of
* an existing bookmark.
*
* @return void
*/
public function testEditAllowedBookmarkId()
{
}
/**
* Test if editAllowed() works when passing a bookmark
* row.
*
* @return void
*/
public function testEditAllowedBookmarkRow()
{
}
/**
* Test if editAllowed() returns false when the bookmark
* specified by the ID does not exist.
*
* @return void
*/
public function testEditAllowedIdNotFound()
{
$this->assertFalse($this->bs->editAllowed(98765));
}
/**
* Verify that getBookmark() returns false when the
* bookmark cannot be found.