aliens/SemanticScuttle
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

The method attachTags was raising a Notice error, fix it and adds a test for this situation.

Browse source
This commit is contained in:
Ricardo Soares de Lima 2012-12-09 16:08:02 -02:00 committed by Christian Weiske
parent 3e2d817fc7
commit 2f865db513
2 changed files with 22 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/SemanticScuttle/Service/Bookmark2Tag.php
View file

@ -97,7 +97,7 @@ class SemanticScuttle_Service_Bookmark2Tag extends SemanticScuttle_DbService
$tags_count = is_array($tags)?count($tags):0; $tags_count = is_array($tags)?count($tags):0;
if (is_array($tags)) {
foreach($tags as $i => $tag) { foreach($tags as $i => $tag) {
$tags[$i] = trim(utf8_strtolower($tags[$i])); $tags[$i] = trim(utf8_strtolower($tags[$i]));
if ($fromApi) { if ($fromApi) {
@ -105,6 +105,7 @@ class SemanticScuttle_Service_Bookmark2Tag extends SemanticScuttle_DbService
$tags[$i] = convertTag($tags[$i], 'in'); $tags[$i] = convertTag($tags[$i], 'in');
} }
} }
}
if ($tags_count > 0) { if ($tags_count > 0) {
// Remove system tags // Remove system tags

15
tests/Bookmark2TagTest.php
View file

@ -89,6 +89,21 @@ class Bookmark2TagTest extends TestBase
); );
} }
public function testAttachTagsWithEmptyStringAddsSystemUnfiled()
{
$originalDisplayErros = ini_get('display_errors');
$originalErrorReporting = ini_get('error_reporting');
ini_set('display_errors', 1);
error_reporting(E_ALL);
$bid = $this->addBookmark(null, null, 0, '');
$this->assertEquals(
array('system:unfiled'),
$this->b2ts->getTagsForBookmark($bid, true)
);
ini_set('display_errors', $originalDisplayErros);
error_reporting($originalErrorReporting);
}
public function testAttachTagsWithSomeEmptyTags() public function testAttachTagsWithSomeEmptyTags()
{ {
$bid = $this->addBookmark(null, null, 0, array()); $bid = $this->addBookmark(null, null, 0, array());