Manga collection software for Maemo 5 https://code.ryuslash.org/eye-on-manga/atom?h=master 2013-09-14T13:43:36Z 2013-09-14T13:43:36Z Tom Willemse 2013-09-14T13:43:36Z urn:sha1:0c4d0f8163772dd953d16411ba3283f0819e03f5 2013-09-14T13:23:46Z Tom Willemse 2013-09-14T13:23:46Z urn:sha1:c16bfb866ab831764e6cea3793bc6529f129ab0c When certain actions can't be completed messages are now shown. 2013-09-14T13:21:53Z Tom Willemse 2013-09-14T13:21:53Z urn:sha1:4a483777bfa1b797a3e8ecd0f2a6c85cd56a98b8 Prepared statements were already being used, but wrong. Instead of creating a string with the right information the SQL should contain parameters which should be bound by other functions. 2013-09-14T11:18:20Z Tom Willemse 2013-09-14T11:18:20Z urn:sha1:96b2395daa2b9b9a20052b53e94d285c82b480ce In the future this should be expanded to include why adding it failed. 2013-09-14T11:00:28Z Tom Willemse 2013-09-14T11:00:28Z urn:sha1:03f8c415ab676732566773004524e2f5f01b7a4f When creating a new manga with a name containing a quote (') it would fail. No message was shown to indicate it had failed and the manga was not added. This was caused by not quoting the quote in the SQL. All SQL queries should use prepared statements in order to make no mistakes quoting quotes and other things. 2013-05-03T01:22:37Z Tom Willemse 2013-05-03T01:22:37Z urn:sha1:f1bf8ecbe889cbb00ac03d1bc26b0fe3b5a3cca9 2013-05-02T22:34:43Z Tom Willemse 2013-05-02T22:34:43Z urn:sha1:760a836e5557ddc707430dfa57f7012336203e1e 2012-10-25T22:25:51Z Tom Willemsen 2012-10-25T22:25:51Z urn:sha1:33b73cac14f28e91cd90e0fb98579bf7690f637f * src/data.c (data_delete_manga): New function, deletes a manga and its associated volumes. (data_update_manga): Extra free. * src/eom-detail-window.c (add_menu): Add a "Delete" button to the menu. (on_delete): New function. Shows a confirmation dialog and if the user pressed "Ok" tries to delete the manga and close the window. * src/eom-main-window.c (on_row_activated): Connect to the `hide' signal instead of the `delete-event' signal. I couldn't find how te emit my own `delete-event' signal, then I found that hide works both when I close a window and when the window manager does it. 2012-10-25T19:15:50Z Tom Willemsen 2012-10-25T19:15:50Z urn:sha1:7ffc87d99d0435146358c6ea1dd90ddaae294f51 * src/data.c (data_update_manga): When updating, set `current_qty' to the lesser of `current_qty' and `total_qty' so that current will never exceed total. If the update went well remove any volumes that have numbers greater than the `total_qty'. * src/eom-detail-window.c (eom_detail_window_load): Get to upper bound of rows, if I need 1.5 rows I actually need 2 rows, what was I thinking? Clear both tables of children before filling them up again. (cb_destroy): New function. Just calls destroy in `widget', but `gtk_widget_destroy' doesn't seem like a valid `GtkCallback'. (on_volume_toggled): When adding a volume fails, revert one from `current_qty'. Don't mess with `self->manga->current_qty', just reset the manga id, otherwise we will know that there should be one more or less volume, but won't show it in the manga's volumes collection. 2012-10-24T22:25:24Z Tom Willemsen 2012-10-24T22:25:24Z urn:sha1:337a0ba2d28f837138aeebda5eda6fb566f3c39b * src/eom-detail-window.c (eom_detail_window_load): If the currently selected manga's `total_qty' is `0', take, for viewing/editing purposes, the manga's `current_qty' + `1' instead. (on_volume_toggled): If the current manga's `total_qty' is `0' reload the screen after toggling a manga as collected.