From 5a8327be1dc3cba69296dbf82c6b2320cc3a0e2f Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Fri, 19 Nov 2010 06:51:01 +0100
Subject: Fix bug #3111254: Search in my_watchlist results in error
---
doc/ChangeLog | 1 +
1 file changed, 1 insertion(+)
(limited to 'doc')
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 0a60bff..60401d4 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -6,6 +6,7 @@ ChangeLog for SemantiScuttle
- Fix bug in getTagsForBookmarks() that fetched all tags
- Fix bug #3073215: Updating bookmark time does not work
- Fix bug #3074816: French translation breaks edit javascript
+- Fix bug #3111254: Search in my_watchlist results in error
- Show error message on mysqli connection errors
- Implement patch #3059829: update FR_CA translation
- Update php-gettext library to 1.0.10
--
cgit v1.2.3-54-g00ecf
From 6d752be4de3f08840d4453dfcfefd469fb79d45a Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Mon, 14 Feb 2011 17:53:31 +0100
Subject: documentation todo
---
doc/developers/doc-TODO | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 doc/developers/doc-TODO
(limited to 'doc')
diff --git a/doc/developers/doc-TODO b/doc/developers/doc-TODO
new file mode 100644
index 0000000..69f6907
--- /dev/null
+++ b/doc/developers/doc-TODO
@@ -0,0 +1,4 @@
+- Which fields are searched?
+ title, description, private note, username, tags
+
+- What are [isbn] and so for?
--
cgit v1.2.3-54-g00ecf
From a46146d01605624e8d8f040699f7c70f92c04773 Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Mon, 14 Feb 2011 18:13:59 +0100
Subject: Fix bug #3178597: Broken link to context in gsearch admin index page
---
doc/ChangeLog | 5 +++++
www/gsearch/index.php | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
(limited to 'doc')
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 60401d4..ee74bc9 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -13,6 +13,11 @@ ChangeLog for SemantiScuttle
- api/posts/add respects the "replace" parameter now
+0.97.2 - 2011-02-XX
+-------------------
+- Fix bug #3178597: Broken link to context in gsearch admin index page
+
+
0.97.1 - 2010-09-30
-------------------
This is a security release! We do highly recommend to update
diff --git a/www/gsearch/index.php b/www/gsearch/index.php
index 585536a..70be05e 100644
--- a/www/gsearch/index.php
+++ b/www/gsearch/index.php
@@ -31,7 +31,9 @@ if($GLOBALS['enableGoogleCustomSearch']==false) {
echo '
';
echo T_('Admin tips: ');
echo T_('To refresh manually Google Custom Search Engine, goes to: ');
- echo 'http://www.google.com/coop/cse/cref
';
+ echo 'http://www.google.com/coop/cse/cref'
+ . '
';
echo T_('If no result appears, check that all the urls are valid in the admin section.');
echo '
';
--
cgit v1.2.3-54-g00ecf
From 96f7172de0123a92cd635f6d8c38d267b73749c7 Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Tue, 15 Feb 2011 07:56:20 +0100
Subject: move changes into 0.97.2 where I merged them
---
doc/ChangeLog | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
(limited to 'doc')
diff --git a/doc/ChangeLog b/doc/ChangeLog
index ee74bc9..2fa0f20 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -5,8 +5,6 @@ ChangeLog for SemantiScuttle
-------------------
- Fix bug in getTagsForBookmarks() that fetched all tags
- Fix bug #3073215: Updating bookmark time does not work
-- Fix bug #3074816: French translation breaks edit javascript
-- Fix bug #3111254: Search in my_watchlist results in error
- Show error message on mysqli connection errors
- Implement patch #3059829: update FR_CA translation
- Update php-gettext library to 1.0.10
@@ -16,6 +14,8 @@ ChangeLog for SemantiScuttle
0.97.2 - 2011-02-XX
-------------------
- Fix bug #3178597: Broken link to context in gsearch admin index page
+- Fix bug #3074816: French translation breaks edit javascript
+- Fix bug #3111254: Search in my_watchlist results in error
0.97.1 - 2010-09-30
--
cgit v1.2.3-54-g00ecf
From 4b6e2ea2bcddea9bfc28a7a2951002dbd70dfed1 Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Tue, 15 Feb 2011 08:00:00 +0100
Subject: another merged bugfix
---
doc/ChangeLog | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(limited to 'doc')
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 2fa0f20..b205f2f 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -4,7 +4,6 @@ ChangeLog for SemantiScuttle
0.9X.X - 2010-XX-XX
-------------------
- Fix bug in getTagsForBookmarks() that fetched all tags
-- Fix bug #3073215: Updating bookmark time does not work
- Show error message on mysqli connection errors
- Implement patch #3059829: update FR_CA translation
- Update php-gettext library to 1.0.10
@@ -16,6 +15,7 @@ ChangeLog for SemantiScuttle
- Fix bug #3178597: Broken link to context in gsearch admin index page
- Fix bug #3074816: French translation breaks edit javascript
- Fix bug #3111254: Search in my_watchlist results in error
+- Fix bug #3073215: Updating bookmark time does not work
0.97.1 - 2010-09-30
--
cgit v1.2.3-54-g00ecf
From 66ee4cbe40a56aa3c9b71427ee51c6b371eb3053 Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Wed, 16 Feb 2011 00:45:06 +0100
Subject: set release date of 0.97.2
---
doc/ChangeLog | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(limited to 'doc')
diff --git a/doc/ChangeLog b/doc/ChangeLog
index b205f2f..212b4e3 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -10,7 +10,7 @@ ChangeLog for SemantiScuttle
- api/posts/add respects the "replace" parameter now
-0.97.2 - 2011-02-XX
+0.97.2 - 2011-02-17
-------------------
- Fix bug #3178597: Broken link to context in gsearch admin index page
- Fix bug #3074816: French translation breaks edit javascript
--
cgit v1.2.3-54-g00ecf
From 0dd5540bfbad7cd75a1eecd96a245aa512356338 Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Wed, 16 Feb 2011 08:49:01 +0100
Subject: Fix bug #3065284: AjaxVote problem with Webkit browsers
---
doc/ChangeLog | 1 +
www/jsScuttle.php | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)
(limited to 'doc')
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 212b4e3..acfce25 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -16,6 +16,7 @@ ChangeLog for SemantiScuttle
- Fix bug #3074816: French translation breaks edit javascript
- Fix bug #3111254: Search in my_watchlist results in error
- Fix bug #3073215: Updating bookmark time does not work
+- Fix bug #3065284: AjaxVote problem with Webkit browsers
0.97.1 - 2010-09-30
diff --git a/www/jsScuttle.php b/www/jsScuttle.php
index f37da78..c166755 100644
--- a/www/jsScuttle.php
+++ b/www/jsScuttle.php
@@ -155,7 +155,10 @@ function processVotingResult() {
var bmnode = document.getElementById('bmv-'+bookmark);
bmnode.parentNode.replaceChild(
- response.getElementsByTagName('html')[0].firstChild,
+ xmlhttp.responseXML.importNode(
+ response.getElementsByTagName('html')[0].firstChild,
+ true
+ ),
bmnode
);
}
--
cgit v1.2.3-54-g00ecf
From 3e9e2154a6ec7e4a1ab34b16f9e7ab9ea5c7f109 Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Tue, 15 Mar 2011 07:59:03 +0100
Subject: Fix bug #3187177: Wrong URL / Export XML Bookmarks
---
data/templates/editprofile.tpl.php | 2 +-
doc/ChangeLog | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
(limited to 'doc')
diff --git a/data/templates/editprofile.tpl.php b/data/templates/editprofile.tpl.php
index b55d250..232b1d3 100644
--- a/data/templates/editprofile.tpl.php
+++ b/data/templates/editprofile.tpl.php
@@ -58,7 +58,7 @@ $this->includeTemplate($GLOBALS['top_include']);
|
/
- /
+ /
|
diff --git a/doc/ChangeLog b/doc/ChangeLog
index acfce25..6144a81 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -8,6 +8,7 @@ ChangeLog for SemantiScuttle
- Implement patch #3059829: update FR_CA translation
- Update php-gettext library to 1.0.10
- api/posts/add respects the "replace" parameter now
+- Fix bug #3187177: Wrong URL / Export XML Bookmarks
0.97.2 - 2011-02-17
--
cgit v1.2.3-54-g00ecf
From 82ada0d75f249733936a0826b115b20cba0657ab Mon Sep 17 00:00:00 2001
From: Christian Weiske
Date: Tue, 15 Mar 2011 19:13:14 +0100
Subject: Implement request #3054906: Show user's full name instead of nickname
---
.../bookmarkcommondescriptionedit.tpl.php | 3 +-
data/templates/bookmarks.tpl.php | 3 +-
data/templates/sidebar.block.users.php | 2 +-
data/templates/tagcommondescriptionedit.tpl.php | 3 +-
data/templates/users.tpl.php | 9 ++++-
doc/ChangeLog | 5 +--
src/SemanticScuttle/Model/UserArray.php | 41 ++++++++++++++++++++++
src/SemanticScuttle/Service/Bookmark.php | 3 +-
src/SemanticScuttle/header.php | 1 +
www/rss.php | 2 +-
10 files changed, 63 insertions(+), 9 deletions(-)
create mode 100644 src/SemanticScuttle/Model/UserArray.php
(limited to 'doc')
diff --git a/data/templates/bookmarkcommondescriptionedit.tpl.php b/data/templates/bookmarkcommondescriptionedit.tpl.php
index af5909a..807c58b 100644
--- a/data/templates/bookmarkcommondescriptionedit.tpl.php
+++ b/data/templates/bookmarkcommondescriptionedit.tpl.php
@@ -30,7 +30,8 @@ window.onload = function() {
if(strlen($description['cdDatetime'])>0) {
echo T_('Last modification:').' '.$description['cdDatetime'].', ';
$lastUser = $userservice->getUser($description['uId']);
- echo ''.$lastUser['username'].'';
+ echo ''
+ . SemanticScuttle_Model_UserArray::getName($lastUser) . '';
}
?>
diff --git a/data/templates/bookmarks.tpl.php b/data/templates/bookmarks.tpl.php
index e32d3c9..c404358 100644
--- a/data/templates/bookmarks.tpl.php
+++ b/data/templates/bookmarks.tpl.php
@@ -309,7 +309,8 @@ if ($currenttag!= '') {
$copy .= T_('you');
} else {
$copy .= ''
- . $row['username'] . '';
+ . SemanticScuttle_Model_UserArray::getName($row)
+ . '';
}
// Udders!
diff --git a/data/templates/sidebar.block.users.php b/data/templates/sidebar.block.users.php
index 3ad18bc..826871e 100644
--- a/data/templates/sidebar.block.users.php
+++ b/data/templates/sidebar.block.users.php
@@ -18,7 +18,7 @@ if ($lastUsers && count($lastUsers) > 0) {
foreach ($lastUsers as $row) {
echo '';
echo '';
- echo $row['username'];
+ echo SemanticScuttle_Model_UserArray::getName($row);
echo '';
echo ' ('.T_('bookmarks').')';
echo ' |
';
diff --git a/data/templates/tagcommondescriptionedit.tpl.php b/data/templates/tagcommondescriptionedit.tpl.php
index d3a006a..f938f93 100644
--- a/data/templates/tagcommondescriptionedit.tpl.php
+++ b/data/templates/tagcommondescriptionedit.tpl.php
@@ -20,7 +20,8 @@ window.onload = function() {
if(strlen($description['cdDatetime'])>0) {
echo T_('Last modification:').' '.$description['cdDatetime'].', ';
$lastUser = $userservice->getUser($description['uId']);
- echo ''.$lastUser['username'].'';
+ echo ''
+ . SemanticScuttle_Model_UserArray::getName($lastUser) . '';
}
?>
diff --git a/data/templates/users.tpl.php b/data/templates/users.tpl.php
index c209f94..fa92bef 100644
--- a/data/templates/users.tpl.php
+++ b/data/templates/users.tpl.php
@@ -14,7 +14,14 @@ if ($users && count($users) > 0) {
'.$row['username'].' ('.T_('profile').' '.T_('created in').' '.date('M Y',strtotime($row['uDatetime'])).') : '.T_('bookmarks').'';
+ echo ''
+ . SemanticScuttle_Model_UserArray::getName($row) . ''
+ . ' ('
+ . T_('profile') . ' '
+ . T_('created in') . ' '
+ . date('M Y', strtotime($row['uDatetime'])) . ')'
+ . ' : '
+ . T_('bookmarks') . '';
}
?>
diff --git a/doc/ChangeLog b/doc/ChangeLog
index 6144a81..4c93a9a 100644
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -3,12 +3,13 @@ ChangeLog for SemantiScuttle
0.9X.X - 2010-XX-XX
-------------------
+- Fix bug #3187177: Wrong URL / Export XML Bookmarks
- Fix bug in getTagsForBookmarks() that fetched all tags
-- Show error message on mysqli connection errors
+- Implement request #3054906: Show user's full name instead of nickname
- Implement patch #3059829: update FR_CA translation
+- Show error message on mysqli connection errors
- Update php-gettext library to 1.0.10
- api/posts/add respects the "replace" parameter now
-- Fix bug #3187177: Wrong URL / Export XML Bookmarks
0.97.2 - 2011-02-17
diff --git a/src/SemanticScuttle/Model/UserArray.php b/src/SemanticScuttle/Model/UserArray.php
new file mode 100644
index 0000000..a0d9c9b
--- /dev/null
+++ b/src/SemanticScuttle/Model/UserArray.php
@@ -0,0 +1,41 @@
+
+ * @license GPL http://www.gnu.org/licenses/gpl.html
+ * @link http://sourceforge.net/projects/semanticscuttle
+ */
+
+/**
+ * Mostly static methods that help working with a user row array from database.
+ *
+ * @category Bookmarking
+ * @package SemanticScuttle
+ * @author Christian Weiske
+ * @license GPL http://www.gnu.org/licenses/gpl.html
+ * @link http://sourceforge.net/projects/semanticscuttle
+ */
+class SemanticScuttle_Model_UserArray
+{
+ /**
+ * Returns full user name as specified in the profile if it is set,
+ * otherwise the nickname/loginname is returned.
+ *
+ * @param array $row User row array from database
+ *
+ * @return string Full name or username
+ */
+ public static function getName($row)
+ {
+ if (isset($row['name']) && $row['name']) {
+ return $row['name'];
+ }
+ return $row['username'];
+ }
+}
+?>
\ No newline at end of file
diff --git a/src/SemanticScuttle/Service/Bookmark.php b/src/SemanticScuttle/Service/Bookmark.php
index 6f8a172..a30ad5f 100644
--- a/src/SemanticScuttle/Service/Bookmark.php
+++ b/src/SemanticScuttle/Service/Bookmark.php
@@ -734,7 +734,8 @@ class SemanticScuttle_Service_Bookmark extends SemanticScuttle_DbService
if (SQL_LAYER == 'mysql4') {
$query_1 .= 'SQL_CALC_FOUND_ROWS ';
}
- $query_1 .= 'B.*, U.'. $userservice->getFieldName('username');
+ $query_1 .= 'B.*, U.'. $userservice->getFieldName('username')
+ . ', U.name';
$query_2 = ' FROM '. $userservice->getTableName() .' AS U'
. ', '. $this->getTableName() .' AS B';
diff --git a/src/SemanticScuttle/header.php b/src/SemanticScuttle/header.php
index d1a5c29..4fecb8f 100644
--- a/src/SemanticScuttle/header.php
+++ b/src/SemanticScuttle/header.php
@@ -68,6 +68,7 @@ require_once 'SemanticScuttle/Service.php';
require_once 'SemanticScuttle/DbService.php';
require_once 'SemanticScuttle/Service/Factory.php';
require_once 'SemanticScuttle/functions.php';
+require_once 'SemanticScuttle/Model/UserArray.php';
if (count($GLOBALS['serviceoverrides']) > 0
&& !defined('UNIT_TEST_MODE')
diff --git a/www/rss.php b/www/rss.php
index 6dcfb4c..298d9ba 100644
--- a/www/rss.php
+++ b/www/rss.php
@@ -116,7 +116,7 @@ foreach ($bookmarks_tmp as $key => $row) {
'title' => $row['bTitle'],
'link' => $_link,
'description' => $row['bDescription'],
- 'creator' => $row['username'],
+ 'creator' => SemanticScuttle_Model_UserArray::getName($row),
'pubdate' => $_pubdate,
'tags' => $row['tags']
);
--
cgit v1.2.3-54-g00ecf