From b5ac1fa2a33ae046fa785d9938dcd0d5274b7ce1 Mon Sep 17 00:00:00 2001
From: Tom Willemse
Date: Mon, 10 Jun 2024 21:09:15 -0700
Subject: Make sure to check users for being false

---
 data/templates/default/bookmarkcommondescriptionedit.tpl.php    | 9 +++++++--
 data/templates/default/bookmarks.tpl.php                        | 2 +-
 data/templates/default/sidebar.block.menu.php                   | 2 +-
 data/templates/default/tagcommondescriptionedit.tpl.php         | 9 +++++++--
 data/templates/minimal/bookmarkcommondescriptionedit.tpl.php    | 9 +++++++--
 data/templates/minimal/bookmarks.tpl.php                        | 2 +-
 data/templates/minimal/sidebar.block.menu.php                   | 2 +-
 data/templates/minimal/tagcommondescriptionedit.tpl.php         | 9 +++++++--
 data/templates/sscuttlizr/bookmarkcommondescriptionedit.tpl.php | 9 +++++++--
 data/templates/sscuttlizr/bookmarks.tpl.php                     | 2 +-
 data/templates/sscuttlizr/sidebar.block.menu.php                | 2 +-
 data/templates/sscuttlizr/tagcommondescriptionedit.tpl.php      | 9 +++++++--
 12 files changed, 48 insertions(+), 18 deletions(-)

(limited to 'data/templates')

diff --git a/data/templates/default/bookmarkcommondescriptionedit.tpl.php b/data/templates/default/bookmarkcommondescriptionedit.tpl.php
index 807c58b..306086e 100644
--- a/data/templates/default/bookmarkcommondescriptionedit.tpl.php
+++ b/data/templates/default/bookmarkcommondescriptionedit.tpl.php
@@ -30,8 +30,13 @@ window.onload = function() {
 	if(strlen($description['cdDatetime'])>0) {
 	   echo T_('Last modification:').' '.$description['cdDatetime'].', ';
 	   $lastUser = $userservice->getUser($description['uId']);
-	   echo  '<a href="'.createURL('profile', $lastUser['username']).'">'
-           . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+       if ($lastUser) {
+           echo  '<a href="'.createURL('profile', $lastUser['username']).'">'
+                            . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+       }
+       else {
+           echo 'Unknown user';
+       }
 	}
 	?>
     </td>
diff --git a/data/templates/default/bookmarks.tpl.php b/data/templates/default/bookmarks.tpl.php
index 2a3d169..0f88a60 100644
--- a/data/templates/default/bookmarks.tpl.php
+++ b/data/templates/default/bookmarks.tpl.php
@@ -86,7 +86,7 @@ if ($userservice->isLoggedOn()) {
 /* personal tag description */
 if($currenttag!= '' && $user!='') {
 	$userObject = $userservice->getUserByUsername($user);
-	if($tagservice->getDescription($currenttag, $userObject['uId'])) { ?>
+	if($userObject && $tagservice->getDescription($currenttag, $userObject['uId'])) { ?>
 
 <p class="commondescription"><?php
 $pDescription = $tagservice->getDescription($currenttag, $userObject['uId']);
diff --git a/data/templates/default/sidebar.block.menu.php b/data/templates/default/sidebar.block.menu.php
index 94a9fa2..dfb2c25 100644
--- a/data/templates/default/sidebar.block.menu.php
+++ b/data/templates/default/sidebar.block.menu.php
@@ -63,7 +63,7 @@ if (sizeof($menuTags) > 0 || ($userid != 0 && $userid === $logged_on_userid)) {
 </table>
 
 <?php $cUser = $userservice->getUser($userid); ?>
-<?php if($userid>0): ?>
+<?php if($cUser && $userid>0): ?>
 <?php if($userid==$logged_on_userid): ?>
 <p style="text-align:right"><a href="<?php echo createURL('alltags', $cUser['username']); ?>" title="<?php echo T_('See all your tags')?>"><?php echo T_('all your tags'); ?></a> →</p>
 <?php else: ?>
diff --git a/data/templates/default/tagcommondescriptionedit.tpl.php b/data/templates/default/tagcommondescriptionedit.tpl.php
index 207cfd2..f52d5b0 100644
--- a/data/templates/default/tagcommondescriptionedit.tpl.php
+++ b/data/templates/default/tagcommondescriptionedit.tpl.php
@@ -20,8 +20,13 @@ window.onload = function() {
 	if(strlen($description['cdDatetime'])>0) {
 	   echo T_('Last modification:').' '.$description['cdDatetime'].', ';
 	   $lastUser = $userservice->getUser($description['uId']);
-	   echo  '<a href="' . createURL('profile', $lastUser['username']) . '">'
-           . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+       if ($lastUser) {
+           echo  '<a href="' . createURL('profile', $lastUser['username']) . '">'
+                             . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+       }
+       else {
+           echo 'Unknown user';
+       }
 	}
 	?>
     </td>
diff --git a/data/templates/minimal/bookmarkcommondescriptionedit.tpl.php b/data/templates/minimal/bookmarkcommondescriptionedit.tpl.php
index b1114d7..4629d72 100644
--- a/data/templates/minimal/bookmarkcommondescriptionedit.tpl.php
+++ b/data/templates/minimal/bookmarkcommondescriptionedit.tpl.php
@@ -33,8 +33,13 @@ window.onload = function() {
 				if(strlen($description['cdDatetime'])>0) {
 					echo T_('Last modification:').' '.$description['cdDatetime'].', ';
 					$lastUser = $userservice->getUser($description['uId']);
-					echo  '<a href="'.createURL('profile', $lastUser['username']).'">'
-								. SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    if ($lastUser) {
+                        echo  '<a href="'.createURL('profile', $lastUser['username']).'">'
+                                         . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    }
+                    else {
+                        echo 'Unknown user';
+                    }
 				}
 				?>
 					</td>
diff --git a/data/templates/minimal/bookmarks.tpl.php b/data/templates/minimal/bookmarks.tpl.php
index 1510d44..86749bc 100644
--- a/data/templates/minimal/bookmarks.tpl.php
+++ b/data/templates/minimal/bookmarks.tpl.php
@@ -87,7 +87,7 @@ if ($userservice->isLoggedOn()) {
 /* personal tag description */
 if($currenttag!= '' && $user!='') {
 	$userObject = $userservice->getUserByUsername($user);
-	if($tagservice->getDescription($currenttag, $userObject['uId'])) { ?>
+	if($userObject && $tagservice->getDescription($currenttag, $userObject['uId'])) { ?>
 
 <p class="commondescription"><?php
 $pDescription = $tagservice->getDescription($currenttag, $userObject['uId']);
diff --git a/data/templates/minimal/sidebar.block.menu.php b/data/templates/minimal/sidebar.block.menu.php
index 94a9fa2..dfb2c25 100644
--- a/data/templates/minimal/sidebar.block.menu.php
+++ b/data/templates/minimal/sidebar.block.menu.php
@@ -63,7 +63,7 @@ if (sizeof($menuTags) > 0 || ($userid != 0 && $userid === $logged_on_userid)) {
 </table>
 
 <?php $cUser = $userservice->getUser($userid); ?>
-<?php if($userid>0): ?>
+<?php if($cUser && $userid>0): ?>
 <?php if($userid==$logged_on_userid): ?>
 <p style="text-align:right"><a href="<?php echo createURL('alltags', $cUser['username']); ?>" title="<?php echo T_('See all your tags')?>"><?php echo T_('all your tags'); ?></a> →</p>
 <?php else: ?>
diff --git a/data/templates/minimal/tagcommondescriptionedit.tpl.php b/data/templates/minimal/tagcommondescriptionedit.tpl.php
index e46c184..bde2ff8 100644
--- a/data/templates/minimal/tagcommondescriptionedit.tpl.php
+++ b/data/templates/minimal/tagcommondescriptionedit.tpl.php
@@ -24,8 +24,13 @@ window.onload = function() {
 				if(strlen($description['cdDatetime'])>0) {
 					echo T_('Last modification:').' '.$description['cdDatetime'].', ';
 					$lastUser = $userservice->getUser($description['uId']);
-					echo  '<a href="' . createURL('profile', $lastUser['username']) . '">'
-								. SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    if ($lastUser) {
+                        echo  '<a href="' . createURL('profile', $lastUser['username']) . '">'
+                                          . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    }
+                    else {
+                        echo 'Unknown user';
+                    }
 				}
 				?>
 					</td>
diff --git a/data/templates/sscuttlizr/bookmarkcommondescriptionedit.tpl.php b/data/templates/sscuttlizr/bookmarkcommondescriptionedit.tpl.php
index b1114d7..4629d72 100644
--- a/data/templates/sscuttlizr/bookmarkcommondescriptionedit.tpl.php
+++ b/data/templates/sscuttlizr/bookmarkcommondescriptionedit.tpl.php
@@ -33,8 +33,13 @@ window.onload = function() {
 				if(strlen($description['cdDatetime'])>0) {
 					echo T_('Last modification:').' '.$description['cdDatetime'].', ';
 					$lastUser = $userservice->getUser($description['uId']);
-					echo  '<a href="'.createURL('profile', $lastUser['username']).'">'
-								. SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    if ($lastUser) {
+                        echo  '<a href="'.createURL('profile', $lastUser['username']).'">'
+                                         . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    }
+                    else {
+                        echo 'Unknown user';
+                    }
 				}
 				?>
 					</td>
diff --git a/data/templates/sscuttlizr/bookmarks.tpl.php b/data/templates/sscuttlizr/bookmarks.tpl.php
index 2df30db..c87a337 100644
--- a/data/templates/sscuttlizr/bookmarks.tpl.php
+++ b/data/templates/sscuttlizr/bookmarks.tpl.php
@@ -87,7 +87,7 @@ if ($userservice->isLoggedOn()) {
 /* personal tag description */
 if($currenttag!= '' && $user!='') {
 	$userObject = $userservice->getUserByUsername($user);
-	if($tagservice->getDescription($currenttag, $userObject['uId'])) { ?>
+	if($userObject && $tagservice->getDescription($currenttag, $userObject['uId'])) { ?>
 
 <p class="commondescription"><?php
 $pDescription = $tagservice->getDescription($currenttag, $userObject['uId']);
diff --git a/data/templates/sscuttlizr/sidebar.block.menu.php b/data/templates/sscuttlizr/sidebar.block.menu.php
index 94a9fa2..dfb2c25 100644
--- a/data/templates/sscuttlizr/sidebar.block.menu.php
+++ b/data/templates/sscuttlizr/sidebar.block.menu.php
@@ -63,7 +63,7 @@ if (sizeof($menuTags) > 0 || ($userid != 0 && $userid === $logged_on_userid)) {
 </table>
 
 <?php $cUser = $userservice->getUser($userid); ?>
-<?php if($userid>0): ?>
+<?php if($cUser && $userid>0): ?>
 <?php if($userid==$logged_on_userid): ?>
 <p style="text-align:right"><a href="<?php echo createURL('alltags', $cUser['username']); ?>" title="<?php echo T_('See all your tags')?>"><?php echo T_('all your tags'); ?></a> →</p>
 <?php else: ?>
diff --git a/data/templates/sscuttlizr/tagcommondescriptionedit.tpl.php b/data/templates/sscuttlizr/tagcommondescriptionedit.tpl.php
index e46c184..bde2ff8 100644
--- a/data/templates/sscuttlizr/tagcommondescriptionedit.tpl.php
+++ b/data/templates/sscuttlizr/tagcommondescriptionedit.tpl.php
@@ -24,8 +24,13 @@ window.onload = function() {
 				if(strlen($description['cdDatetime'])>0) {
 					echo T_('Last modification:').' '.$description['cdDatetime'].', ';
 					$lastUser = $userservice->getUser($description['uId']);
-					echo  '<a href="' . createURL('profile', $lastUser['username']) . '">'
-								. SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    if ($lastUser) {
+                        echo  '<a href="' . createURL('profile', $lastUser['username']) . '">'
+                                          . SemanticScuttle_Model_UserArray::getName($lastUser) . '</a>';
+                    }
+                    else {
+                        echo 'Unknown user';
+                    }
 				}
 				?>
 					</td>
-- 
cgit v1.2.3-54-g00ecf