From fee364b94e1bafdb751b93014b43c5576bd9e039 Mon Sep 17 00:00:00 2001 From: cweiske Date: Mon, 2 Nov 2009 09:41:32 +0000 Subject: [PATCH] basic developer rules git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@504 b3834d28-1941-0410-a4f8-b48e95affb8f --- doc/developers/rules | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 doc/developers/rules diff --git a/doc/developers/rules b/doc/developers/rules new file mode 100644 index 0000000..701a215 --- /dev/null +++ b/doc/developers/rules @@ -0,0 +1,30 @@ +Rules for developers +==================== + +1. Coding style +--------------- +SemanticScuttle uses the PEAR Coding Standards. +While quite some parts still do not follow them, all of the +code will be coverted to them. When developing new code, +adhere to it. + +A helpful tool to check your coding style is PHP CodeSniffer, +http://pear.php.net/package/PHP_CodeSniffer + + +2. Unit tests +------------- +At least the service and model classes have unit tests. +If you fix things in there, make sure you +a) do not break the tests or +b) fix the tests if the old behavior was broken + + +3. Keep security in mind +------------------------ +As a web application, there are several attack vectors to SemanticScuttle. +When processing user input (form variables, URL parameters) +be sure to convert and validate them. If you expect a bookmark id, +there is no reason not to cast the variable to (int). + +Filter input, escape output.